[MySQL] Add Dockerfile and instructions for Cloud Run #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kurtisvg
approved these changes
Nov 19, 2019
|
|
||
| # Copy local code to the container image. | ||
| WORKDIR /app | ||
| COPY pom.xml . |
There was a problem hiding this comment.
Any particular reason for copying the POM separate?
There was a problem hiding this comment.
We've been doing it across all samples in order to reduce the change of copying over files that aren't needed.
| @@ -64,14 +64,24 @@ | |||
| <artifactId>HikariCP</artifactId> | |||
| <version>3.4.1</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.slf4j</groupId> | |||
There was a problem hiding this comment.
There was an annoying logging warning about slf4j not being found. Though it doesn't break anything it was distracting. I can remove if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new dependencies because of annoying logging warning.