KMS: update README.md #1776
Merged
KMS: update README.md #1776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added more info to KMS README
googlebot
added
the
cla: yes
changed PROJECT_ID to GOOGLE_CLOUD_PROJECT
elharo
reviewed
Dec 2, 2019
elharo
reviewed
Dec 2, 2019
cleaned url
added permissions info
lesv
approved these changes
Dec 6, 2019
|
@dansanche Do you need us to merge? |
|
I can do the merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added info about environment variables and enabling the API to the KMS README