fix: use IdTokenCredentials for IAP request #1790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dzlier-gcp
approved these changes
Dec 9, 2019
|
Do you need us to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1643
In google-auth-library 0.17.0 (the latest 0.18.0 is preferred though), we introduced a new interface
IdTokenProviderwhich a subset ofGoogleCredentialstypes can provide (ServiceAccountCredentialsandComputeEngineCredentialsboth implementIdTokenProvider). The interface abstract the mechanism for fetching an Open ID token using the means available for that type of credential.This should also drastically simplify the sample code and not require you to handle the JWT encoding/Open ID implementation.