Skip to content

bigtable hbase: read and filter snippets #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 14, 2020
Merged

bigtable hbase: read and filter snippets #1947

merged 7 commits into from
Jan 14, 2020

Conversation

billyjacobson
Copy link
Member

No description provided.

@billyjacobson
Read and filter snippets for Hbase Bigtable
b7cf321 
Reads done
Filters WIP, issues with Pass and ColRange. Some nuances to sort out
between HBase and other clients still
@billyjacobson
Filter snippets
89f39be
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 14, 2020
@billyjacobson billyjacobson added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2020
@billyjacobson billyjacobson changed the title Bigtable read filters hbase bigtable hbase: read and filter snippets Jan 14, 2020
@billyjacobson billyjacobson marked this pull request as ready for review January 14, 2020 16:17
@billyjacobson billyjacobson requested review from a team and kurtisvg January 14, 2020 16:17
lesv
lesv approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment - should there be a warning re- key design and add's - what we are doing here is for illustrative purposes - in a real design, you wouldn't wan't to have common key prefixes for all your add's. (It creates hot spots in the database)

@billyjacobson billyjacobson merged commit f81a9a5 into master Jan 14, 2020
@billyjacobson billyjacobson deleted the bigtable-read-filters-hbase branch January 14, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@kurtisvg kurtisvg Awaiting requested review from kurtisvg

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@billyjacobson @lesv @googlebot @kokoro-team