Skip to content

Update ExampleSystemTest.java #2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

Update ExampleSystemTest.java #2984

merged 1 commit into from
May 28, 2020

Conversation

kurtisvg
Copy link
Contributor

Fixes #2928

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass (mvn -P lint clean verify)
    • (Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)
  • Please merge this PR for me once it is approved.

@kurtisvg kurtisvg requested review from lesv and a team May 28, 2020 15:24
@kurtisvg kurtisvg self-assigned this May 28, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2020
@kurtisvg kurtisvg added the automerge Merge the pull request once unit tests and other checks pass. label May 28, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit db7dc84 into master May 28, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the kurtisvg-patch-1 branch May 28, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@kurtisvg kurtisvg

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

functions.ExampleSystemTest: helloHttp_shouldRunWithFunctionsFramework failed
3 participants
@kurtisvg @lesv @googlebot