Skip to content

Update token creation for Cloud Run Markdown sample #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

Update token creation for Cloud Run Markdown sample #3443

merged 1 commit into from
Jul 30, 2020

Conversation

averikitsch
Copy link
Contributor

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@averikitsch averikitsch requested a review from a team July 30, 2020 23:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2020
@averikitsch averikitsch requested a review from grayside July 30, 2020 23:31
@averikitsch
Copy link
Contributor Author

@grayside Updating the java sample since the node.js sample already uses the new library.

@lesv lesv merged commit bdc9374 into master Jul 30, 2020
@lesv lesv deleted the markdown-auth branch July 30, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@grayside grayside Awaiting requested review from grayside

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averikitsch @lesv