Skip to content

Commit f7794a3

Browse files
committed
Address feedback.
1 parent c43b768 commit f7794a3

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

cloud-sql/mysql/sqlalchemy/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ secure solution such as [Cloud KMS](https://cloud.google.com/kms/) to help keep
3030

3131
## Running locally
3232

33-
To run this application locally, download and install the cloud_sql_proxy by
33+
To run this application locally, download and install the `cloud_sql_proxy` by
3434
following the instructions [here](https://cloud.google.com/sql/docs/mysql/sql-proxy#install).
3535

3636
Once the proxy is ready, use the following command to start the proxy in the
@@ -58,7 +58,7 @@ Navigate towards `http://127.0.0.1:8080` to verify your application is running c
5858

5959
## Google App Engine Standard
6060

61-
To run on GAE-Standard, create an AppEngine project by following the setup for these
61+
To run on GAE-Standard, create an App Engine project by following the setup for these
6262
[instructions](https://cloud.google.com/appengine/docs/standard/python3/quickstart#before-you-begin).
6363

6464
First, update `app.yaml` with the correct values to pass the environment

cloud-sql/mysql/sqlalchemy/app.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
runtime: python37
1616

17+
# Remember - storing secrets in plaintext is potentially unsafe. Consider using
18+
# something like https://cloud.google.com/kms/ to help keep secrets secret.
1719
env_variables:
1820
CLOUD_SQL_INSTANCE_NAME: <MY-PROJECT>:<INSTANCE-REGION>:<MY-DATABASE>
1921
DB_USER: my-db-user

cloud-sql/mysql/sqlalchemy/main.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@
2020
import sqlalchemy
2121

2222

23-
# Saving credentials in environment variables is convent, but not secure
24-
# - consider a more secure solution such as https://cloud.google.com/kms/ to
25-
# help keep secrets safe.
23+
# Remember - storing secrets in plaintext is potentially unsafe. Consider using
24+
# something like https://cloud.google.com/kms/ to help keep secrets secret.
2625
db_user = os.environ.get("DB_USER")
2726
db_pass = os.environ.get("DB_PASS")
2827
db_name = os.environ.get("DB_NAME")

0 commit comments

Comments
 (0)