bug fix - flaky bot issue #8431 (#8482)

changes
1. Fix `test_list_namespace`: Update the check to do validation based on namespace object's name attribute. This change is required to due a bug in class's __eq__ method & flaky bot issue.

2. Update `namespace` method, to ensure that proper clean-up of created object. As of now, in case of failure, we found un wanted object created but did not clean-up

Author: msampathkumar

servicedirectory/quickstart_test.py

@@ -38,17 +38,18 @@ def namespace(client):
     namespace = servicedirectory_v1.Namespace(
         name=client.namespace_path(PROJECT_ID, LOCATION_ID, NAMESPACE_ID))
 
-    client.create_namespace(
-        parent=f'projects/{PROJECT_ID}/locations/{LOCATION_ID}',
-        namespace=namespace,
-        namespace_id=NAMESPACE_ID,
-    )
+    try:
+        client.create_namespace(
+            parent=f'projects/{PROJECT_ID}/locations/{LOCATION_ID}',
+            namespace=namespace,
+            namespace_id=NAMESPACE_ID,
+        )
 
-    yield namespace
-
-    client.delete_namespace(name=namespace.name)
+        yield namespace
+    finally:
+        client.delete_namespace(name=namespace.name)
 
 
 def test_list_namespace(namespace):
-    assert namespace in quickstart.list_namespaces(PROJECT_ID,
-                                                   LOCATION_ID).namespaces
+    google_cloud_namespaces = quickstart.list_namespaces(PROJECT_ID, LOCATION_ID).namespaces
+    assert namespace.name in [_namespace.name for _namespace in google_cloud_namespaces]