Fork cloud sql sample into a separate postgres sample #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
andrewsg
approved these changes
Jul 17, 2017
| # Replace project and instance with the values obtained when configuring your | ||
| # Cloud SQL instance. | ||
| beta_settings: | ||
| cloud_sql_instances: INSTANCE_CONNECTION_NAME |
There was a problem hiding this comment.
Why do we need both this beta_setting and the SQLALCHEMY_DATABASE_URI? Networking or something?
There was a problem hiding this comment.
the beta setting actually tells the cloud sql proxy running on your instance to create the socket for the cloud sql instance.
|
|
||
|
|
||
| def test_index(): | ||
| main.db.create_all() |
There was a problem hiding this comment.
Do we have any way to safely tear these test tables down afterwards?
There was a problem hiding this comment.
We do, but it's not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.