Skip to content

[DLP] Implemented samples for inspect on datastore, gcs and bigquery data and send results to SCC #10289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Avani-Thakker-Crest
Copy link
Contributor

@Avani-Thakker-Crest Avani-Thakker-Crest commented Jun 22, 2023

Description

This PR includes 3 samples for inspecting data and send results to SCC and their tests are implemented using mocking approach:

  1. inspect_datastore_send_to_scc
  2. inspect_gcs_send_to_scc
  3. inspect_bigquery_send_to_scc

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@Avani-Thakker-Crest Avani-Thakker-Crest requested review from a team as code owners June 22, 2023 19:35
@snippet-bot
Copy link

snippet-bot bot commented Jun 22, 2023

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: dlp Issues related to the Sensitive Data Protection API. labels Jun 22, 2023
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 23, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 23, 2023
@annadata annadata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2023
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 27, 2023
@annadata annadata assigned annadata and unassigned manjaepark Jun 27, 2023
@annadata annadata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2023
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 27, 2023
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2023
Copy link
Contributor

@m-strzelczyk m-strzelczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the tests are using capsys - we'd love to move away from using capsys and inspect the return values of methods, but that's a non-blocking comment.

@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2023
@kweinmeister kweinmeister added the automerge Merge the pull request once unit tests and other checks pass. label Jul 6, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 595e4a6 into GoogleCloudPlatform:main Jul 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants