Skip to content

Create scikit-xg-predict.py #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2018

Conversation

thedriftofwords
Copy link
Contributor

Creating new file for inclusion in docs.

This predict_json method uses exactly the same code as in https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/ml_engine/online_prediction/predict.py#L28. The only difference is that the definition of instances at line 29 is updated to be more appropriate for scikit and xgb. Kathy provided the updated definition.

This predict_json method uses exactly the same code as in https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/ml_engine/online_prediction/predict.py#L28. The only difference is that the definition of instances at line 29 is updated to be more appropriate for scikit and xgb. Kathy provided the updated definition.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 22, 2018
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 614e2f2 into GoogleCloudPlatform:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants