Skip to content

Update main.py #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Update main.py #1810

merged 3 commits into from
Nov 21, 2018

Conversation

josteinl
Copy link
Contributor

@josteinl josteinl commented Nov 1, 2018

Fix crash if no translation is needed. Change so that detect_text(), save_result() and translate_text() all use 'lang' in message.
Add check for 'und' (undefined) language. Then don't try to translate.

Fix crash if no translation is needed. Change so that detect_text(), save_result() and translate_text() all use 'lang' in message.
Add check for 'und' (undefined) language. Then don't try to translate.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 1, 2018
@josteinl
Copy link
Contributor Author

josteinl commented Nov 1, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 1, 2018
@engelke
Copy link
Contributor

engelke commented Nov 20, 2018

Thanks, but the change to 'lang' for the property caused test failures because it is not in the event object. Take a look and see if you want to update this PR.

Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit eccb52e into GoogleCloudPlatform:master Nov 21, 2018
@josteinl josteinl deleted the patch-1 branch November 22, 2018 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants