Skip to content

Update Transfer Service examples #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wpjohnson
Copy link
Contributor

@wpjohnson wpjohnson commented Nov 20, 2018

  • Edit comments to indicate that the Transfer Service API expects UTC, not US Pacific TimeZone.
  • Edit function/module docstrings to clarify each example's behavior.
  • Allow for scheduling at a second granularity.

@theacodes, could you review/merge these changes?

Will Johnson added 3 commits November 20, 2018 18:06
Google Cloud Storage Transfer Service API requests require the
|Schedule| to be in UTC [1]. This |Schedule| also supports specifying
the |startTimeOfDay| with seconds granularity.

[1] https://cloud.google.com/storage-transfer/docs/reference/rest/v1/transferJobs#Schedule
Google Cloud Storage Transfer Service API requests require the
|Schedule| to be in UTC [1]. This |Schedule| also supports specifying
the |startTimeOfDay| with seconds granularity.

[1] https://cloud.google.com/storage-transfer/docs/reference/rest/v1/transferJobs#Schedule
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2018
@wpjohnson
Copy link
Contributor Author

Not quite sure what the review process is for this repo; adding a more recent/active contributor.

@engelke, could you take a look and let me know if I need to do anything else? Thanks!

Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke
Copy link
Contributor

engelke commented Nov 21, 2018 via email

@wpjohnson
Copy link
Contributor Author

Thanks for the quick review! Apparently I'm not authorized to merge into the base branch.

Would you be able to merge this PR or grant me the permission(s) to do so?

@engelke
Copy link
Contributor

engelke commented Nov 21, 2018

Sure, just waiting for Travis tests to run.

@engelke engelke merged commit 8996b42 into GoogleCloudPlatform:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants