Skip to content

Gcf composer trigger #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 26, 2019
Merged

Gcf composer trigger #2415

merged 14 commits into from
Sep 26, 2019

Conversation

leahecole
Copy link
Collaborator

This code will be part of the Triggering DAGs (workflows) tutorial - ping me for internal docs CL if you'd like

@leahecole leahecole requested a review from tswast September 25, 2019 16:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2019
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That IAM sample is trying to handle too many cases in one sample. Maybe we can simplify it for this use case by removing the App Engine logic?

@leahecole leahecole requested a review from tswast September 26, 2019 20:34
@leahecole leahecole merged commit cf12171 into master Sep 26, 2019
@leahecole leahecole deleted the gcf_composer_trigger branch September 26, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants