Skip to content

samples(storage): IAM conditions samples #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 21, 2020
Merged

samples(storage): IAM conditions samples #2730

merged 12 commits into from
Jan 21, 2020

Conversation

jkwlui
Copy link
Collaborator

@jkwlui jkwlui commented Jan 16, 2020

Existing Bucket/IAM samples are updated to use:

  • requested_policy_version=3 to request policy with conditions
  • policy["rolename"] is deprecated, use policy.bindings to access bindings instead.

Added sample to show how to add a conditional binding to an existing Bucket's policy.

@jkwlui jkwlui requested a review from a team as a code owner January 16, 2020 20:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2020
@jkwlui jkwlui requested a review from frankyn January 16, 2020 20:55
@jkwlui jkwlui requested a review from crwilcox as a code owner January 17, 2020 23:29
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jkwlui

@jkwlui jkwlui merged commit a9e1342 into master Jan 21, 2020
@jkwlui jkwlui deleted the iam-conditions-sample branch January 21, 2020 21:36
@jkwlui
Copy link
Collaborator Author

jkwlui commented Jan 22, 2020

The tests passed previously when re-run individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants