Skip to content

feat: adds 'single_utterance' to media translation sample #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 15, 2020
Merged

feat: adds 'single_utterance' to media translation sample #3286

merged 11 commits into from
Apr 15, 2020

Conversation

telpirion
Copy link
Contributor

@telpirion telpirion commented Apr 6, 2020 •
edited
Loading

Change requested by product eng.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2020
tmatsuo
tmatsuo reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some simple explanation on why this change is needed, maybe in the PR description?

@telpirion
Copy link
Contributor Author

Can you add some simple explanation on why this change is needed, maybe in the PR description?

Done.

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 8, 2020 •
edited
Loading

@telpirion
It seems like the test is failing for unrelated reason.
Can you copy this file into this directory?

@kurtisvg FYI it seems like this directory is missing requirements-test.txt.

@telpirion

Or, maybe you just need to rebase to the current master. Anyways, there must be requirements-test.txt.

@telpirion telpirion marked this pull request as ready for review April 13, 2020 16:36
@telpirion telpirion requested a review from a team as a code owner April 13, 2020 16:36
@telpirion telpirion requested a review from nnegrey April 13, 2020 16:36
@telpirion
Copy link
Contributor Author

@telpirion
It seems like the test is failing for unrelated reason.
Can you copy this file into this directory?

@kurtisvg FYI it seems like this directory is missing requirements-test.txt.

@telpirion

Or, maybe you just need to rebase to the current master. Anyways, there must be requirements-test.txt.

Done.

Reviewers: PTAL and approve at your earliest convenience. Thank you!

@telpirion telpirion added the automerge Merge the pull request once unit tests and other checks pass. label Apr 15, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 240190a into master Apr 15, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the media-translation-update branch April 15, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@nnegrey nnegrey nnegrey approved these changes

Assignees

@busunkim96 busunkim96

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@telpirion @tmatsuo @nnegrey @googlebot @busunkim96