-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Correct path for the warmup call #3414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@@ -28,5 +28,5 @@ def test_warmup(): | |||
main.app.testing = True | |||
client = main.app.test_client() | |||
|
|||
r = client.get('/') | |||
r = client.get('/_ah/warmup') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For other reviewers: this is the warmup
route in main.py
python-docs-samples/appengine/standard_python37/warmup/main.py
Lines 27 to 30 in 00e7377
@app.route('/_ah/warmup') | |
def warmup(): | |
# Handle your warmup logic here, e.g. set up a database connection pool | |
return '', 200, {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oittaa Thanks for the contribution!
No description provided.