Skip to content

[datastore] fix: handle datastore eventual consistency #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2020
Merged

[datastore] fix: handle datastore eventual consistency #3448

merged 2 commits into from
Apr 21, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Apr 20, 2020

fixes #2884

@tmatsuo tmatsuo requested a review from andrewsg April 20, 2020 23:17
@tmatsuo tmatsuo requested a review from a team as a code owner April 20, 2020 23:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 21, 2020

This time flask_app_test.test_index is failing. I'll fix that too. A new commit is on the way.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 21, 2020

The second commit is very similar to the first one. I assume it's ok to merge with the admin power.

@tmatsuo tmatsuo merged commit d8dd870 into GoogleCloudPlatform:master Apr 21, 2020
@tmatsuo tmatsuo deleted the fix-datastore branch April 21, 2020 01:29
@tmatsuo tmatsuo mentioned this pull request Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datastore.cloud-ndb.quickstart_test: test_quickstart failed
4 participants
@tmatsuo @andrewsg @googlebot @busunkim96