Skip to content

GCF cloudbuild.yaml: clarify "dir" parameter #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2020
Merged

GCF cloudbuild.yaml: clarify "dir" parameter #3847

merged 3 commits into from
May 20, 2020

Conversation

ace-n
Copy link

@ace-n ace-n commented May 20, 2020

No description provided.

@ace-n ace-n requested a review from grant May 20, 2020 18:37
@ace-n ace-n requested a review from a team as a code owner May 20, 2020 18:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2020
@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented May 20, 2020

Is this file used for any tests? Probably not.

There is a region tag, so I assume it's used in our docs.
How do we know it's working as expected with this change?

@ace-n
Copy link
Author

ace-n commented May 20, 2020 •
edited
Loading

@tmatsuo yes - this is used in our docs.

When I tested this previously (manually), I had to:

  1. Create a test Cloud Source repo
  2. Link it to a test Cloud Build trigger
  3. Push a change to said Cloud Source repo
  4. Confirm the build ran successfully

Historically, we've considered things like that to be "too involved" for an automated testing workflow. Personally I wouldn't mind changing that (e.g. testing gcloud commands and such), but I would like to see that become a {clearly-articulated, team-wide} policy before I update the functions samples.

(Maybe it's worth creating an issue/doc about this and discussing further there, as this PR is a fairly minor change?)

@gcf-merge-on-green gcf-merge-on-green bot merged commit ae45478 into master May 20, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the ace-n-patch-2 branch May 20, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@grant grant grant approved these changes

Assignees

@crwilcox crwilcox

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ace-n @tmatsuo @grant @crwilcox @googlebot