Skip to content

Updated links to tutorial and git repo #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2016
Merged

Updated links to tutorial and git repo #516

merged 3 commits into from
Sep 14, 2016

Conversation

tristanvanech
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 13, 2016
theacodes
theacodes reviewed Sep 13, 2016
View reviewed changes
appengine/standard/firebase/firenotes/README.md
@@ -45,7 +51,7 @@ server with the following command:

dev_appserver.py frontend/app.yaml backend/app.yaml

1. Visit [http://locahost:8080/](http://locahost:8080/) in a web browser.
1. Visit <http://locahost:8080/> in a web browser.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this? It works as a link the way you had it before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, no reason except I learned it was possible to do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the other way, for this and the link to the docs page.

@theacodes
Copy link
Contributor

This branch seems to have conflict, can you try to resolve those?

@tristanvanech
Copy link
Contributor Author

Is it the requirements.txt file? I thought I updated that

@theacodes
Copy link
Contributor

I remembered I have access to your fork and just fixed it for you. Merged.

@theacodes theacodes merged commit d737aa4 into GoogleCloudPlatform:master Sep 14, 2016
@tristanvanech
Copy link
Contributor Author

Thank you!

On Wed, Sep 14, 2016 at 12:17 PM, Jon Wayne Parrott <
[email protected]> wrote:

Merged #516
#516.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#516 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATdq5RZ6l5N4uxlWX2_Vh6sv0U_SFpQAks5qqEg1gaJpZM4J799m
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristanvanech @theacodes @googlebot