-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix(oslogin): Fixing a flaky issue with OSLogin SSH tests #8208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of retrying in this file, is it possible to retry with backoff on the test?
The test itself is already using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM to give this a try.
just looks like you need to update the branch and verify that checks still past and then this is ok to merge. |
Description
Fixes #7277 (again)
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)