Skip to content

fix(oslogin): Fixing a flaky issue with OSLogin SSH tests #8208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 4, 2022

Conversation

m-strzelczyk
Copy link
Contributor

Description

Fixes #7277 (again)

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label bot added api: oslogin Issues related to the Cloud OS Login API API. samples Issues that are directly related to samples. labels Jul 25, 2022
@m-strzelczyk m-strzelczyk marked this pull request as ready for review July 25, 2022 11:23
@m-strzelczyk m-strzelczyk requested a review from a team as a code owner July 25, 2022 11:23
@leahecole leahecole added the blunderbuss: assign Instruct blunderbuss to assign someone label Jul 25, 2022
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Jul 25, 2022
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of retrying in this file, is it possible to retry with backoff on the test?

@m-strzelczyk
Copy link
Contributor Author

Instead of retrying in this file, is it possible to retry with backoff on the test?

The test itself is already using the @retry decorator, but it seems to fail anyway... or perhaps the decorator is not working as intended?

Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM to give this a try.

@iennae
Copy link
Contributor

iennae commented Jul 29, 2022

just looks like you need to update the branch and verify that checks still past and then this is ok to merge.

@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2022
@m-strzelczyk m-strzelczyk merged commit 2afd6c9 into main Aug 4, 2022
@m-strzelczyk m-strzelczyk deleted the issue-7277 branch August 4, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: oslogin Issues related to the Cloud OS Login API API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute.oslogin.service_account_ssh_test: test_main failed
7 participants