Skip to content

Add BigQuery Remote Vision Function code sample #8426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 8, 2022

Conversation

autoerr
Copy link
Collaborator

@autoerr autoerr commented Oct 17, 2022

Description

First sample for #8425

Checklist

…o detect and extract objects in input images
@autoerr autoerr requested review from shollyman and a team as code owners October 17, 2022 20:57
@snippet-bot
Copy link

snippet-bot bot commented Oct 17, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 17, 2022
@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comments in nox file, but don't consider them blocking if you disagree with them.

@engelke engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2022
@engelke engelke added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 26, 2022
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 26, 2022
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add yourself as the owner for the sample here? https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/.github/CODEOWNERS

A team is preferred if there is one!

@shollyman, could you take a look as BQ owner?

@autoerr autoerr requested a review from a team as a code owner October 26, 2022 21:42
@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 26, 2022
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 26, 2022
@dandhlee dandhlee added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 26, 2022
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Approving for CODEOWNERS.

Adding do not merge until BQ approval is obtained.

@autoerr autoerr requested a review from chalmerlowe as a code owner November 8, 2022 19:51
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 8, 2022
@autoerr autoerr added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 8, 2022
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 8, 2022
@autoerr autoerr removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 8, 2022
@autoerr autoerr added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 8, 2022
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 8, 2022
@autoerr autoerr merged commit d9078cb into GoogleCloudPlatform:main Nov 8, 2022
@autoerr autoerr deleted the vision-remote-function branch November 8, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants