fix(oslogin_tests): Making the test check if the firewall rule got removed #9167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: oslogin
rsamborski
approved these changes
Feb 23, 2023
product-auto-label
bot
removed
the
api: compute
kweinmeister
approved these changes
Feb 27, 2023
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
…moved (#9167) * fix(oslogin_tests): Making the test check if the firewall rule got removed * lint fix --------- Co-authored-by: Karl Weinmeister <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #8429
Current theory is that the test sometimes fail, because the required firewall rule gets deleted by GCE Enforcer. If the test failas and the rule is still there, then we have a problem.