Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Commit 64b295e

Browse files
committed
Merge branch 'SizeSorting' of https://github.com/cftorres/container-diff into SizeSorting
2 parents 4176705 + d5792ae commit 64b295e

17 files changed

+642
-276
lines changed

cmd/root.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,11 @@ func diffImages(image1Arg, image2Arg string, diffArgs []string) error {
123123
}
124124
sort.Strings(sortedTypes)
125125
glog.Info("Retrieving diffs")
126-
diffResults := []utils.Result{}
127-
for _, diffType := range sortedTypes {
126+
diffResults := make([]interface{}, len(diffs))
127+
for i, diffType := range sortedTypes {
128128
diff := diffs[diffType]
129129
if json {
130-
diffResults = append(diffResults, diff.GetStruct().(utils.Result))
130+
diffResults[i] = diff.GetStruct()
131131
} else {
132132
err = diff.OutputText(diffType)
133133
if err != nil {
@@ -182,11 +182,11 @@ func analyzeImage(imageArg string, analyzerArgs []string) error {
182182
}
183183
sort.Strings(sortedTypes)
184184
glog.Info("Retrieving diffs")
185-
analyzeResults := []utils.Result{}
186-
for _, analyzeType := range sortedTypes {
185+
analyzeResults := make([]interface{}, len(analyses))
186+
for i, analyzeType := range sortedTypes {
187187
analysis := analyses[analyzeType]
188188
if json {
189-
analyzeResults = append(analyzeResults, analysis.GetStruct().(utils.Result))
189+
analyzeResults[i] = analysis.GetStruct()
190190
} else {
191191
err = analysis.OutputText(analyzeType)
192192
if err != nil {

differs/differs.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,6 @@ var analyzers = map[string]Analyzer{
3333
"node": NodeAnalyzer{},
3434
}
3535

36-
/*var diffResultMap = map[string]utils.DiffResult{
37-
"HistoryAnalyzer": utils.HistDiffResult,
38-
"FileAnalyzer": utils.DirDiffResult,
39-
"AptAnalyzer": utils.SingleVersionPackageDiffResult,
40-
"PipAnalyzer": utils.MultiVersionPackageDiffResult,
41-
"NodeAnalyzer": utils.MultiVersionPackageDiffResult,
42-
}*/
43-
4436
func (req DiffRequest) GetDiff() (map[string]utils.Result, error) {
4537
img1 := req.Image1
4638
img2 := req.Image2

0 commit comments

Comments
 (0)