This repository was archived by the owner on Mar 27, 2024. It is now read-only.
WIP: adds a simple layer cache. #102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
reviewed
Sep 22, 2017
| } | ||
|
|
||
| func NewFileCache(rootDir string) (*FileCache, error) { | ||
| if err := os.MkdirAll(rootDir, 0700); err != nil { |
There was a problem hiding this comment.
not a big deal, but maybe make this 600? shouldn't need exec permissions on anything in here, just R/W
| } | ||
| if _, err := io.Copy(l, r); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
since you're getting a new layer after adding to the cache, should you r.Close() here?
|
Does this cache have a lifecycle? If I create a few |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.