This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Use go integration tests #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #50 |
r2d4
force-pushed
the
integration-tests
branch
from
736a084 to
4640581
Compare
nkubala
reviewed
Aug 30, 2017
| language: go | ||
| os: linux |
There was a problem hiding this comment.
I think you can specify multiple OSes here, should we run these tests on all platforms?
os:
- linux
- osx
- windows
There was a problem hiding this comment.
I tried this, but travis always has a backlog of OSX jobs (its at ~800 now). I think its probably best to just test on one platform for now.
| aptModified = "gcr.io/gcp-runtimes/apt-modified" | ||
|
|
||
| // Why is this node-modified:2.0? | ||
| nodeBase = "gcr.io/gcp-runtimes/node-modified:2.0" |
There was a problem hiding this comment.
hmm...I wonder if the source code for these images is lying around anywhere, I'm not a huge fan of this being abstracted
There was a problem hiding this comment.
Yeah as a TODO: get rid of these + get rid of the _expected.json files.
r2d4
force-pushed
the
integration-tests
branch
2 times, most recently
from
3f703d0 to
fee6d56
Compare
r2d4
force-pushed
the
integration-tests
branch
from
fee6d56 to
784cf7c
Compare
nkubala
approved these changes
Aug 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can run these in parallel once we fix #54
Changed the travis configuration to
make test integrationinstead of bash script.