Add bazel builds for container-diff. #90
Conversation
|
cc @r2d4 |
There was a problem hiding this comment.
LGTM. I think we just need some sort of plan on how we're going to keep this up to date.
Should test.sh run bazel run //:gazelle? That would force any contributors to have the bazel toolchain installed.
Maybe make test should try to download and run the gazelle binary, which would only require the go toolchain to be installed.
BUILD
Outdated
|
|
||
| gazelle( | ||
| name = "gazelle", | ||
| external = "vendored", |
There was a problem hiding this comment.
add in
build_tags = [
"container_image_ostree_stub",
"containers_image_openpgp",
],There was a problem hiding this comment.
Should test.sh run bazel run //:gazelle? That would force any contributors to have the bazel toolchain installed.
I'm fine with that. Ultimately our downoading/installing of stuff in the minikube makefile causes extra confusion. We could try to move it into a container - but that gets tricky too...
|
Ready for a look. Travis is passing. |
One manual edit in vendor/gorilla/mux/BUILD.bazel to workaround a gazelle bug.