PHPORM-46 Throw an exception when Query\Builder::orderBy() is used with invalid direction

Author: GromNaN

src/Query/Builder.php

@@ -513,11 +513,20 @@ public function distinct($column = false)
 
     /**
      * @inheritdoc
+     * @param  int|string  $direction
      */
     public function orderBy($column, $direction = 'asc')
     {
         if (is_string($direction)) {
-            $direction = (strtolower($direction) == 'asc' ? 1 : -1);
+            $direction = match (strtolower($direction)) {
+                'asc' => 1,
+                'desc' => -1,
+                default => throw new \InvalidArgumentException(sprintf('Order direction must be either "asc" or "desc", "%s" given.', $direction)),
+            };
+        }
+
+        if ($direction !== 1 && $direction !== -1) {
+            throw new \InvalidArgumentException(sprintf('Order direction must be either 1 or -1, "%s" given.', $direction));
         }
 
         if ($column == 'natural') {

tests/QueryBuilderTest.php

@@ -863,4 +863,17 @@ public function testCursor()
             $this->assertEquals($data[$i]['name'], $result['name']);
         }
     }
+
+    /**
+     * @testWith ["dasc"]
+     *           [0]
+     *           [10]
+     *           [true]
+     */
+    public function testOrderByInvalidDirection($direction)
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Order direction must be either ');
+        DB::collection('items')->orderBy('_id', $direction)->get();
+    }
 }