Skip to content

Make compatible with Laravel 5.7 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Make compatible with Laravel 5.7 #121

merged 1 commit into from
Sep 5, 2018

Conversation

rodrigopedra
Copy link
Contributor

Updates composer.json and adds new test environments to .travis.yml to make compatible with Laravel 5.7

@rodrigopedra
Copy link
Contributor Author

I had to tweak the hhvm to keep the tests running on it.

  1. Hold on HHVM version 3.18

    It was the last version to fully support trusty, and to be largely compatible with PHP 5.6, which is the version Laravel 5.4 officially supports.

    https://hhvm.com/blog/2017/02/15/hhvm-3-18.html

  2. Use phpunit 5.7 when running HHVM tests

    phpunit version 6 and up are not compatible with HHVM:

    Unable to build with travis and hhvm after upgrading to phpunit 6.x sebastianbergmann/phpunit#2581 (comment)

    I found the workaround to use a different phpunit version in this Reddit thread:

    https://www.reddit.com/r/HHVM/comments/95m72p/testing_on_travisci/

@rodrigopedra
Copy link
Contributor Author

ping @srmklive

@srmklive srmklive merged commit eca3fb1 into HTMLMin:master Sep 5, 2018
@rodrigopedra
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants