Update README.md to reflect support for Laravel 5.5 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
suggested changes
Sep 2, 2017
README.md
Outdated
| @@ -13,7 +13,7 @@ Laravel HTMLMin is currently maintained by [Raza Mehdi](https://github.com/srmkl | |||
|
|
|||
| ## Installation | |||
|
|
|||
| Laravel HTMLMin requires [PHP](https://php.net) 5.5+. This particular version supports Laravel 5.1, 5.2, 5.3, or 5.4 only. | |||
| Laravel HTMLMin requires [PHP](https://php.net) 5.5+, and supports Laravel 5.1+. | |||
There was a problem hiding this comment.
Not 5.1+, it's 5.1, 5.2, 5.3, 5.4, and 5.5 only.
There was a problem hiding this comment.
No problem. 👍
I'm curious as to why. Is it for some sort of future-proofing?
GrahamCampbell
suggested changes
Sep 2, 2017
README.md
Outdated
| @@ -13,7 +13,7 @@ Laravel HTMLMin is currently maintained by [Raza Mehdi](https://github.com/srmkl | |||
|
|
|||
| ## Installation | |||
|
|
|||
| Laravel HTMLMin requires [PHP](https://php.net) 5.5+, and supports Laravel 5.1+. | |||
| Laravel HTMLMin requires [PHP](https://php.net) 5.5+, and supports Laravel 5.1, 5.2, 5.3, 5.4, and 5.4 only. | |||
GrahamCampbell
suggested changes
Sep 2, 2017
README.md
Outdated
| @@ -13,7 +13,7 @@ Laravel HTMLMin is currently maintained by [Raza Mehdi](https://github.com/srmkl | |||
|
|
|||
| ## Installation | |||
|
|
|||
| Laravel HTMLMin requires [PHP](https://php.net) 5.5+. This particular version supports Laravel 5.1, 5.2, 5.3, or 5.4 only. | |||
| Laravel HTMLMin requires [PHP](https://php.net) 5.5+, and supports Laravel 5.1, 5.2, 5.3, 5.4, and 5.5 only. | |||
There was a problem hiding this comment.
Please keep the text the same. This particular version is correct, not any version,
|
Sorry about the commits. I'm still new to Git & GitHub. 📝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively, you could have it read as this:
This particular version supports Laravel 5.1, 5.2, 5.3, 5.4, or 5.5 only.In any case, I believe that it's important to note that the package supports Laravel 5.5.