Skip to content

[Housekeeping] Update Python & third party packages. Add ruff. #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

daniel-goshev
Copy link
Contributor

Details

In this PR I am updating the python version to 3.12.0 and updating third-party packages.

In addition I've dropped flake8, black & isort and replaced them with ruff - https://pypi.org/project/ruff/.

The changes over the code are due to differences between the old & new formatters.

I've also updated the readme & workflow files to reflect on those changes.

pyproject.toml Outdated
]

# Same as Black.
line-length = 88
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we use default length we do not need to add to pyproject.toml. If you choose some custom length (120 for example) it will make sense

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just continue using 120 and we are good to go.

@daniel-goshev daniel-goshev merged commit a41476a into master Apr 15, 2024
@daniel-goshev daniel-goshev deleted the update-python branch April 15, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants