Skip to content

build(dev-deps): pin dependencies #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024
Merged

build(dev-deps): pin dependencies #725

merged 1 commit into from
Oct 25, 2024

Conversation

ricellis
Copy link
Member

PR summary

Pin development dependencies by hash.

Fixes: s1015

Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features) - N/A
  • Docs have been added / updated (for bug fixes / features) - N/A

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

Transitive development dependencies brought in by range.

What is the new behavior?

Pinned versions of transitive dependencies and hash checking enabled (it is an all-or-nothing in pip).

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is development dependencies only, it does not impact the released SDK.

@ricellis ricellis self-assigned this Oct 25, 2024
@ricellis ricellis force-pushed the s1015-pip-hashes branch 7 times, most recently from 60bd903 to 709f779 Compare October 25, 2024 14:42
@ricellis ricellis merged commit 48fd513 into main Oct 25, 2024
10 checks passed
@ricellis ricellis deleted the s1015-pip-hashes branch October 25, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants