feat: set x-request-id as error trace #736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
If the
x-request-id
header is on a response use it to set the errortrace
field (in preference tox-couch-request-id
, but still usex-couch-request-id
if there is nox-request-id
).Fixes: part of s1037
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
The error
trace
introduced in #719 only handles CouchDB'sx-couch-request-id
header on responses.What is the new behavior?
The error
trace
also handlesx-request-id
header on responses.Does this PR introduce a breaking change?
Other information