Skip to content

feat: set x-request-id as error trace #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

feat: set x-request-id as error trace #736

merged 1 commit into from
Nov 6, 2024

Conversation

ricellis
Copy link
Member

@ricellis ricellis commented Nov 6, 2024

PR summary

If the x-request-id header is on a response use it to set the error trace field (in preference to x-couch-request-id, but still use x-couch-request-id if there is no x-request-id).

Fixes: part of s1037

Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

The error trace introduced in #719 only handles CouchDB's x-couch-request-id header on responses.

What is the new behavior?

The error trace also handles x-request-id header on responses.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ricellis ricellis self-assigned this Nov 6, 2024
@ricellis ricellis merged commit 5978b63 into main Nov 6, 2024
10 checks passed
@ricellis ricellis deleted the s1037-x-request-id branch November 6, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants