refactor(follower): use normal feed for one-off changes #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojito317
approved these changes
Apr 16, 2025
ricellis
approved these changes
Apr 22, 2025
eiri
force-pushed
the
i445-follower-one-off
branch
from
a298a14 to
6db629a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Use normal feed mode for changes follower one-off
FINITEmode.Fixes: s1115 / i445
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
Currently the changes follower uses
longpollfeed type is for both start (LISTEN) andstart_one_off(FINITE) cases.What is the new behavior?
Switch to use the normal feed type for
start_one_off(FINITE) mode to avoid waiting unnecessarily till timeout on empty feeds.Does this PR introduce a breaking change?
Other information