Skip to content

chore(deps): bump go-sdk-core to v5 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2022
Merged

Conversation

dnwe
Copy link
Contributor

@dnwe dnwe commented Apr 28, 2022

PR summary

chore(deps): bump go-sdk-core to v5

  • bump other dependency versions where appropriate too
  • update client-go syntax to context-aware calls

Notably this PR removes the transitive dependency on the deprecated
github.com/dgrijalva/jwt-go library (which is flagged for various CVEs)
as that is no longer pulled in by the v5 go-sdk-core

Fixes: N/A

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

N/A — dependency bumps

What is the new behavior?

N/A — dependency bumps

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dnwe dnwe force-pushed the go-sdk-core-v5 branch 5 times, most recently from 2d7b271 to 3b3b250 Compare April 28, 2022 21:52
- bump other depedency versions where appropriate too
- update client-go syntax to context-aware calls

Notably this PR removes the transitive dependency on the deprecated
github.com/dgrijalva/jwt-go library (which is flagged for various CVEs)
as that is no longer pulled in by the v5 go-sdk-core

Signed-off-by: Dominic Evans <[email protected]>
Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reggeenr reggeenr merged commit 1191a7b into IBM:main May 24, 2022
reggeenr added a commit to reggeenr/code-engine-go-sdk that referenced this pull request Dec 9, 2022
Configure WhiteSource for GitHub Enterprise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants