fix(container_registry_v1): Fix test_get_image_manifest to correctly … #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeyoung3k
force-pushed
the
fix_test_image_manifest
branch
from
c147fed to
1952546
Compare
added 2 commits
April 13, 2023 15:07
…convert type if not dict Signed-off-by: Mike Young <[email protected]>
Signed-off-by: Mike Young <[email protected]>
mikeyoung3k
force-pushed
the
fix_test_image_manifest
branch
from
cf2bc6f to
1fe59c5
Compare
|
I wonder if get_results() is obliged to return a dict ? I'm not python savy enough to know. |
|
Assuming the type hints are accurate, it returns either a dict or a requests.Result: |
|
🎉 This PR is included in version 0.0.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test_get_image_manifest to correctly convert type if not dict
PR summary
Fixes the get_image_manifest_response test to read request.Result types properly
Fixes: https://github.ibm.com/alchemy-registry/team/issues/6432
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
Test failure due to attempting to use a "get" method on class that doesn't have "get"
What is the new behavior?
Create dict from json body if not already a dict
Does this PR introduce a breaking change?
Other information