Skip to content

fix(project): improve testcase and fix dependabot finding #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

jhart1685
Copy link
Member

Signed-off-by: James Hart [email protected]

PR summary

This PR improves one of the integration tests by not making it request vulnerability status on an image list.
npm packages (required for semantic-release only) are also updated to resolve dependabot finding.

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe) - test improvement

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Member

@bainsy88 bainsy88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bainsy88 bainsy88 merged commit 09d59e2 into main Aug 11, 2022
@jhart1685 jhart1685 deleted the listNoVulns branch August 11, 2022 12:44
@ibm-reggie
Copy link
Collaborator

🎉 This PR is included in version 0.0.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants