Skip to content

Commit 7ed431a

Browse files
committed
fix: bump up min supported python version to 3.8
Signed-off-by: Subin Shekhar <[email protected]>
1 parent 8b02c58 commit 7ed431a

9 files changed

+29
-40
lines changed

.pylintrc

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ disable=too-many-arguments,
6161
useless-suppression,
6262
deprecated-pragma,
6363
use-symbolic-message-instead,
64-
invalid-name
64+
invalid-name,
65+
global-statement,
66+
use-implicit-booleaness-not-comparison
6567

6668
# Enable the message, report, category or checker with the given id(s). You can
6769
# either give multiple identifier separated by comma (,) or put this option
@@ -191,14 +193,6 @@ attr-naming-style=snake_case
191193
# style.
192194
#attr-rgx=
193195

194-
# Bad variable names which should always be refused, separated by a comma.
195-
bad-names=foo,
196-
bar,
197-
baz,
198-
toto,
199-
tutu,
200-
tata
201-
202196
# Naming style matching correct class attribute names.
203197
class-attribute-naming-style=any
204198

Makefile

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
# to be ready for development work in the local sandbox.
33
# example: "make setup"
44

5+
LINT_DIRS=iaesdk test/unit test/integration examples
6+
57
setup: deps dev_deps install_project
68

79
all: upgrade_pip setup test-unit lint
@@ -32,7 +34,8 @@ test-examples:
3234
python -m pytest examples
3335

3436
lint:
35-
./pylint.sh && black --check .
37+
python -m pylint ${LINT_DIRS} --exit-zero
38+
black --check ${LINT_DIRS}
3639

3740
lint-fix:
38-
black .
41+
black ${LINT_DIRS}

README.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,14 @@ IBM Analytics Engine v3 is for the Standard Serverless for Apache Spark plan
4040

4141
* An [IBM Cloud][ibm-cloud-onboarding] account.
4242
* An IAM API key to allow the SDK to access your account. Create one [here](https://cloud.ibm.com/iam/apikeys).
43-
* Python 3.7 or above.
43+
* Python 3.8 or above.
4444

4545
## Installation
4646

47-
To install, use `pip` or `easy_install`:
47+
To install, use `pip`:
4848

4949
```bash
50-
pip install --upgrade "iaesdk>=3.2.0"
51-
```
52-
53-
or
54-
55-
```bash
56-
easy_install --upgrade "iaesdk>=3.2.0"
50+
python -m pip install --upgrade iaesdk
5751
```
5852

5953
## Using the SDK

package.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,14 @@
44
"description": "This package.json is being used to manage semantic-release and its dependencies",
55
"license": "Apache-2.0",
66
"devDependencies": {
7-
"semantic-release": "19.0.5",
8-
"@semantic-release/changelog": "6.0.2",
7+
"semantic-release": "21.0.7",
8+
"@semantic-release/changelog": "6.0.3",
99
"@semantic-release/exec": "6.0.3",
1010
"@semantic-release/git": "10.0.1"
1111
},
12+
"overrides": {
13+
"semver": "^7.5.3"
14+
},
1215
"scripts": {
1316
"semantic-release": "semantic-release"
1417
}

requirements-dev.txt

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
1-
# test dependencies
2-
coverage>=4.5.4
3-
pylint>=2.6.0,<3.0.0
4-
pytest>=7.0.1,<8.0.0
5-
pytest-cov>=2.2.1,<3.0.0
6-
pytest-rerunfailures>=3.1
7-
responses>=0.12.1,<1.0.0
8-
black>=22.10
1+
coverage>=7.3.2,<8.0.0
2+
pylint>=3.0.0,<4.0.0
3+
pytest>=7.4.2,<8.0.0
4+
pytest-cov>=4.1.0,<5.0.0
5+
responses>=0.23.3,<1.0.0
6+
black>=23.9.1

requirements.txt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1 @@
1-
requests>=2.26.0,<3.0.0
2-
urllib3>=1.26.0,<2.0.0
3-
python_dateutil>=2.5.3,<3.0.0
4-
ibm_cloud_sdk_core>=3.16.0,<4.0.0
1+
ibm_cloud_sdk_core>=3.18.2,<4.0.0

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env python
2-
# Copyright 2016,2022 IBM All Rights Reserved.
2+
# Copyright 2016,2024 IBM All Rights Reserved.
33
#
44
# Licensed under the Apache License, Version 2.0 (the "License");
55
# you may not use this file except in compliance with the License.
@@ -59,10 +59,10 @@
5959
classifiers=[
6060
"Programming Language :: Python",
6161
"Programming Language :: Python :: 3",
62-
"Programming Language :: Python :: 3.7",
6362
"Programming Language :: Python :: 3.8",
6463
"Programming Language :: Python :: 3.9",
6564
"Programming Language :: Python :: 3.10",
65+
"Programming Language :: Python :: 3.11",
6666
"Development Status :: 4 - Beta",
6767
"Intended Audience :: Developers",
6868
"License :: OSI Approved :: Apache Software License",

test/unit/test_ibm_analytics_engine_api_v2.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ def preprocess_url(operation_path: str):
5858
# Otherwise, return a regular expression that matches one or more trailing /.
5959
if re.fullmatch(".*/+", request_url) is None:
6060
return request_url
61-
else:
62-
return re.compile(request_url.rstrip("/") + "/+")
61+
62+
return re.compile(request_url.rstrip("/") + "/+")
6363

6464

6565
##############################################################################

test/unit/test_ibm_analytics_engine_api_v3.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ def preprocess_url(operation_path: str):
5959
# Otherwise, return a regular expression that matches one or more trailing /.
6060
if re.fullmatch('.*/+', request_url) is None:
6161
return request_url
62-
else:
63-
return re.compile(request_url.rstrip('/') + '/+')
62+
63+
return re.compile(request_url.rstrip('/') + '/+')
6464

6565

6666
def test_get_service_url_for_region():

0 commit comments

Comments
 (0)