Skip to content

Commit 2ed1d5c

Browse files
committed
refactor: Rename cookie jar implementation and remove old Speech to Text logic
1 parent 9d21458 commit 2ed1d5c

File tree

1 file changed

+7
-23
lines changed

1 file changed

+7
-23
lines changed

src/main/java/com/ibm/cloud/sdk/core/http/WatsonCookieJar.java renamed to src/main/java/com/ibm/cloud/sdk/core/http/ServiceCookieJar.java

Lines changed: 7 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -12,31 +12,27 @@
1212
*/
1313
package com.ibm.cloud.sdk.core.http;
1414

15-
import java.net.CookieHandler;
16-
import java.util.ArrayList;
17-
import java.util.List;
18-
1915
import okhttp3.Cookie;
2016
import okhttp3.CookieJar;
2117
import okhttp3.HttpUrl;
2218
import okhttp3.JavaNetCookieJar;
2319

20+
import java.net.CookieHandler;
21+
import java.util.List;
22+
2423
/**
25-
* This is an adapter that uses {@link JavaNetCookieJar} and ignore Speech to Text sessions for session less requests.
24+
* This is an adapter that uses {@link JavaNetCookieJar}.
2625
*
2726
*/
28-
public final class WatsonCookieJar implements CookieJar {
29-
private static final String SESSIONID = "SESSIONID";
30-
private static final String SESSIONS = "sessions";
31-
private static final String SPEECH_TO_TEXT = "speech-to-text";
27+
public final class ServiceCookieJar implements CookieJar {
3228
private JavaNetCookieJar adapter;
3329

3430
/**
3531
* Instantiates a new Watson cookie jar.
3632
*
3733
* @param cookieHandler the cookie handler
3834
*/
39-
public WatsonCookieJar(CookieHandler cookieHandler) {
35+
public ServiceCookieJar(CookieHandler cookieHandler) {
4036
this.adapter = new JavaNetCookieJar(cookieHandler);
4137
}
4238

@@ -58,19 +54,7 @@ public void saveFromResponse(HttpUrl url, List<Cookie> cookies) {
5854
*/
5955
@Override
6056
public List<Cookie> loadForRequest(HttpUrl url) {
61-
List<Cookie> cookies = this.adapter.loadForRequest(url);
62-
63-
// TODO: Removes the SESSIONID for speech to text session lest requests
64-
if (url.encodedPathSegments().contains(SPEECH_TO_TEXT) && !url.encodedPathSegments().contains(SESSIONS)) {
65-
List<Cookie> sessionLessCookies = new ArrayList<Cookie>();
66-
for (Cookie cookie : cookies) {
67-
if (!cookie.name().equalsIgnoreCase(SESSIONID)) {
68-
sessionLessCookies.add(cookie);
69-
}
70-
}
71-
cookies = sessionLessCookies;
72-
}
73-
return cookies;
57+
return this.adapter.loadForRequest(url);
7458
}
7559

7660
}

0 commit comments

Comments
 (0)