Skip to content

feat: added direct link provider sdk support #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Conversation

ajay-malhotra1
Copy link
Contributor

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #12 into master will decrease coverage by 0.01%.
The diff coverage is 88.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   88.94%   88.93%   -0.02%     
==========================================
  Files          34       35       +1     
  Lines       17799    18497     +698     
==========================================
+ Hits        15832    16451     +619     
- Misses       1967     2046      +79     
Impacted Files Coverage Δ
...oud_networking_services/direct_link_provider_v2.py 88.66% <88.66%> (ø)
ibm_cloud_networking_services/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d737622...b367c4c. Read the comment docs.

@ajay-malhotra1
Copy link
Contributor Author

@KumarGanesanIBM Can you please check the failures for SSL certificate. I tried it 4-5 times but they are continuously failing.

Thanks

@KumarGanesanIBM
Copy link
Contributor

@KumarGanesanIBM Can you please check the failures for SSL certificate. I tried it 4-5 times but they are continuously failing.

Thanks

@ajay-malhotra1
Hi Ajay,
The Given SSL certificate as env variable, got expired.
Updated it and started travis build.
https://travis-ci.com/github/IBM/networking-python-sdk/jobs/386802209
Please give it some time to finish and rebase your code and start your build process
Thanks...

@ajay-malhotra1 ajay-malhotra1 merged commit cdfa579 into master Sep 18, 2020
@ajay-malhotra1 ajay-malhotra1 deleted the provider branch September 18, 2020 06:40
@ajay-malhotra1
Copy link
Contributor Author

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants