Skip to content

feat(filters): added filters #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2021
Merged

feat(filters): added filters #43

merged 1 commit into from
Oct 5, 2021

Conversation

shailajamahara
Copy link
Contributor

PR summary

added filters

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #43 (5269b44) into master (de81ab8) will increase coverage by 0.02%.
The diff coverage is 89.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   88.40%   88.43%   +0.02%     
==========================================
  Files          37       38       +1     
  Lines       24751    25410     +659     
==========================================
+ Hits        21882    22472     +590     
- Misses       2869     2938      +69     
Impacted Files Coverage Δ
ibm_cloud_networking_services/filters_v1.py 89.51% <89.51%> (ø)
ibm_cloud_networking_services/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de81ab8...5269b44. Read the comment docs.

Copy link
Member

@MalarvizhiK MalarvizhiK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shailajamahara shailajamahara merged commit def999b into master Oct 5, 2021
@ajay-malhotra1
Copy link
Contributor

🎉 This PR is included in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants