Skip to content

feat: Added Gateway Route Reports Integration tests for PYTHON-SDK. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

cacarrilloc
Copy link
Contributor

@cacarrilloc cacarrilloc commented Nov 15, 2021

PR summary

The Integration Tests for PYTHON-SDK needed to be updated to cover the new Gateway Route Reports APIs.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

All tests passing without the Route Report integration tests.

What is the new behavior?

All tests passing with the Route Report integration tests.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Related to https://github.ibm.com/CloudBBS/ts-planning/issues/3374

@cacarrilloc cacarrilloc self-assigned this Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #51 (23df799) into master (bcc871e) will increase coverage by 0.05%.
The diff coverage is 93.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   88.76%   88.82%   +0.05%     
==========================================
  Files          39       39              
  Lines       26255    26619     +364     
==========================================
+ Hits        23305    23644     +339     
- Misses       2950     2975      +25     
Impacted Files Coverage Δ
...oud_networking_services/transit_gateway_apis_v1.py 91.29% <93.04%> (+0.89%) ⬆️
ibm_cloud_networking_services/filters_v1.py 88.90% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc871e...23df799. Read the comment docs.

@cacarrilloc cacarrilloc force-pushed the transit-sdk-integration-tests branch 5 times, most recently from 689292d to 6fe877b Compare November 16, 2021 01:57
The Integration Tests for PYTHON-SDK needed to be updated to cover the new Gateway Route Reports APIs.
@cacarrilloc cacarrilloc force-pushed the transit-sdk-integration-tests branch from 0bb9992 to c1bee9a Compare November 16, 2021 14:10
@cacarrilloc cacarrilloc merged commit 883b8ea into master Nov 16, 2021
@cacarrilloc cacarrilloc deleted the transit-sdk-integration-tests branch November 16, 2021 14:35
@ajay-malhotra1
Copy link
Contributor

🎉 This PR is included in version 0.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants