Skip to content

feat(direct_link): renamed DirectLinkApisV1 to DirectLinkV1 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

ajay-malhotra1
Copy link
Contributor

PR summary

renamed DirectLinkApisV1 to DirectLinkV1

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

renamed DirectLinkApisV1 to DirectLinkV1

Other information

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #6 into master will decrease coverage by 17.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
- Coverage   87.99%   70.72%   -17.28%     
===========================================
  Files          34       35        +1     
  Lines        5890     7313     +1423     
===========================================
- Hits         5183     5172       -11     
- Misses        707     2141     +1434     
Impacted Files Coverage Δ
ibm_cloud_networking_services/direct_link_v1.py 89.95% <ø> (ø)
ibm_cloud_networking_services/__init__.py 100.00% <100.00%> (ø)
...m_cloud_networking_services/direct_link_apis_v1.py 0.00% <0.00%> (-90.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41137c6...a8cd293. Read the comment docs.

@ajay-malhotra1 ajay-malhotra1 merged commit 49bece9 into master Jul 31, 2020
@ajay-malhotra1 ajay-malhotra1 deleted the dl-name-change branch July 31, 2020 21:16
@ajay-malhotra1
Copy link
Contributor Author

🎉 This PR is included in version 0.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant