Skip to content

fix: remove unused setuptools import #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix: remove unused setuptools import #269

merged 2 commits into from
Jul 29, 2024

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Jul 29, 2024

PR summary

This commit removes an unused setuptools import from the setup.py
file. More details about the setuptools mess can be found in the following
PR: IBM/python-sdk-core#203

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pyrooka pyrooka requested a review from padamstx July 29, 2024 13:23
@pyrooka pyrooka self-assigned this Jul 29, 2024
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but just had a question to be addressed before merging.

Signed-off-by: Norbert Biczo <[email protected]>
@pyrooka pyrooka merged commit 0d52373 into main Jul 29, 2024
4 checks passed
@pyrooka pyrooka deleted the nb/setuptools-changes branch July 29, 2024 19:09
ibm-devx-sdk pushed a commit that referenced this pull request Jul 29, 2024
## [0.55.2](v0.55.1...v0.55.2) (2024-07-29)

### Bug Fixes

* remove unused setuptools import ([#269](#269)) ([0d52373](0d52373))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.55.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants