Skip to content

fix(Global Tagging): re-gen service with latest API definition #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2020

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Sep 25, 2020

PR summary

This PR contains:

  • a re-gen of the service and unit test code for the Global Tagging service
  • a renovated integration test starting with a new generated test
  • a new request examples file

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Sep 25, 2020
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #50 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   94.03%   94.04%           
=======================================
  Files          16       16           
  Lines       15609    15628   +19     
=======================================
+ Hits        14678    14697   +19     
  Misses        931      931           
Impacted Files Coverage Δ
ibm_platform_services/global_tagging_v1.py 92.12% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18304cb...2dcfff0. Read the comment docs.

@padamstx padamstx merged commit a833687 into master Sep 30, 2020
@padamstx padamstx deleted the regen-tagging branch September 30, 2020 14:49
ibm-devx-automation pushed a commit that referenced this pull request Sep 30, 2020
## [0.12.2](v0.12.1...v0.12.2) (2020-09-30)

### Bug Fixes

* **Global Tagging:** re-gen service with latest API definition ([#50](#50)) ([a833687](a833687))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.12.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants