Skip to content

chore: asoc configuration #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021
Merged

chore: asoc configuration #70

merged 1 commit into from
Jan 13, 2021

Conversation

christiancompton
Copy link

This PR tells our code scanning tool to ignore the test directory on its subsequent runs.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #70 (d275a0c) into master (4abcedb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files          21       21           
  Lines       19706    19706           
=======================================
  Hits        18444    18444           
  Misses       1262     1262           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4abcedb...d275a0c. Read the comment docs.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I left a question about the "examples" directory.

<Configuration>
<Targets>
<Target path=".">
<Exclude>test/</Exclude>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also exclude the "examples" directory?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added! examples was not causing code scan problems, but it makes sense to add it too.

@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants