Skip to content

fix(Case Management): re-gen service and add examples #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 18, 2021
Merged

fix(Case Management): re-gen service and add examples #80

merged 6 commits into from
Feb 18, 2021

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Feb 15, 2021 •
edited
Loading

PR summary

This PR adds examples to the Case Management service.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pyrooka pyrooka requested a review from padamstx February 15, 2021 18:43
@codecov
Copy link

codecov bot commented Feb 15, 2021 •
edited
Loading

Codecov Report

Merging #80 (23e214b) into main (17dc954) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files          21       21           
  Lines       19771    19771           
=======================================
  Hits        18503    18503           
  Misses       1268     1268
Impacted Files Coverage Δ
ibm_platform_services/case_management_v1.py 91.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17dc954...23e214b. Read the comment docs.

padamstx
padamstx requested changes Feb 16, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one comment about how to print out the result of "download_file".

examples/test_case_management_v1_examples.py Outdated
file = response.get_result()

print('Attachment content-type:', response.get_headers()['content-type'])
print('Attachment contents:', file)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to do something slightly different to print out the contents of the downloaded "file". When I run the examples, i get this output:

Attachment content-type: application/octet-stream
Attachment contents: <Response [200]>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totally right. I forgot to check the verbose logs. With the modification I have just pushed it looks like this:
Attachment contents: b'This is the content of the file to upload.
WDYT?

padamstx
padamstx approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

padamstx
padamstx approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit fb784fc into main Feb 18, 2021
@padamstx padamstx deleted the update-cm branch February 18, 2021 21:13
ibm-devx-automation pushed a commit that referenced this pull request Feb 18, 2021
@semantic-release-bot
chore(release): 0.17.9 release notes
18be5b0 
## [0.17.9](v0.17.8...v0.17.9) (2021-02-18)

### Bug Fixes

* **build:** transition default branch master -> main ([17dc954](17dc954))
* **Case Management:** re-gen service and add examples ([#80](#80)) ([fb784fc](fb784fc))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyrooka @ibm-devx-automation @padamstx