chore(service): Validate that service_url is set in the prepare_request

Author: ehdsouza

ibm_cloud_sdk_core/base_service.py

@@ -164,6 +164,9 @@ def prepare_request(self, method, url, headers=None,
                         params=None, data=None, files=None, **kwargs):
         request = {'method': method}
 
+        # validate the service url is set
+        if not self.service_url:
+            raise ValueError('The service_url is required')
         request['url'] = self.service_url + url
 
         headers = remove_null_values(headers) if headers else {}

test/test_base_service.py

@@ -420,3 +420,9 @@ def test_json():
     service = AnyServiceV1('2018-11-20', authenticator=NoAuthAuthenticator())
     req = service.prepare_request('POST', url='', headers={'X-opt-out': True}, data={'hello': 'world'})
     assert req.get('data') == "{\"hello\": \"world\"}"
+
+def test_service_url_not_set():
+    service = BaseService(service_url='', authenticator=NoAuthAuthenticator(), display_name='Watson')
+    with pytest.raises(ValueError) as err:
+        service.prepare_request('POST', url='')
+    assert str(err.value) == 'The service_url is required'