fix(value error): Throw error if authenticator is not set

Author: ehdsouza

ibm_cloud_sdk_core/base_service.py

@@ -56,10 +56,12 @@ def __init__(self,
 
         self._set_user_agent_header(self._build_user_agent())
 
-        if self.authenticator:
-            if not isinstance(self.authenticator, Authenticator):
-                raise ValueError(
-                    'authenticator should be of type Authenticator')
+        if not self.authenticator:
+            raise ValueError('authenticator must be provided')
+
+        if not isinstance(self.authenticator, Authenticator):
+            raise ValueError(
+                'authenticator should be of type Authenticator')
 
         if display_name:
             service_name = display_name.replace(' ', '_').lower()

test/test_base_service.py

@@ -81,7 +81,7 @@ def get_access_token():
 
 @responses.activate
 def test_url_encoding():
-    service = AnyServiceV1('2017-07-07')
+    service = AnyServiceV1('2017-07-07', authenticator=NoauthAuthenticator())
 
     # All characters in path0 _must_ be encoded in path segments
     path0 = ' \"<>^`{}|/\\?#%[]'
@@ -112,7 +112,7 @@ def test_url_encoding():
 
 @responses.activate
 def test_http_config():
-    service = AnyServiceV1('2017-07-07')
+    service = AnyServiceV1('2017-07-07', authenticator=NoauthAuthenticator())
     responses.add(
         responses.GET,
         service.default_url,
@@ -128,7 +128,7 @@ def test_http_config():
 
 
 def test_fail_http_config():
-    service = AnyServiceV1('2017-07-07')
+    service = AnyServiceV1('2017-07-07', authenticator=NoauthAuthenticator())
     with pytest.raises(TypeError):
         service.with_http_config(None)
 
@@ -196,7 +196,7 @@ def test_for_cp4d():
 
 
 def test_disable_ssl_verification():
-    service1 = AnyServiceV1('2017-07-07', disable_ssl_verification=True)
+    service1 = AnyServiceV1('2017-07-07', authenticator=NoauthAuthenticator(), disable_ssl_verification=True)
     assert service1.disable_ssl_verification is True
 
     service1.set_disable_ssl_verification(False)
@@ -212,7 +212,7 @@ def test_disable_ssl_verification():
 
 @responses.activate
 def test_http_head():
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
     expectedHeaders = {'Test-Header1': 'value1', 'Test-Header2': 'value2'}
     responses.add(
         responses.HEAD,
@@ -230,7 +230,7 @@ def test_http_head():
 
 @responses.activate
 def test_response_with_no_body():
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
     responses.add(responses.GET, service.default_url, status=200, body=None)
 
     response = service.any_service_call()
@@ -257,7 +257,7 @@ def test_request_server_error():
             'error': 'internal server error'
         }),
         content_type='application/json')
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
     try:
         prepped = service.prepare_request('GET', url='')
         service.send(prepped)
@@ -274,7 +274,7 @@ def test_request_success_json():
             'foo': 'bar'
         }),
         content_type='application/json')
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
     prepped = service.prepare_request('GET', url='')
     detailed_response = service.send(prepped)
     assert detailed_response.get_result() == {'foo': 'bar'}
@@ -296,7 +296,7 @@ def test_request_success_response():
             'foo': 'bar'
         }),
         content_type='application/json')
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
     prepped = service.prepare_request('GET', url='')
     detailed_response = service.send(prepped)
     assert detailed_response.get_result() == {"foo": "bar"}
@@ -311,7 +311,7 @@ def test_request_fail_401():
             'foo': 'bar'
         }),
         content_type='application/json')
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
     try:
         prepped = service.prepare_request('GET', url='')
         service.send(prepped)
@@ -339,7 +339,7 @@ def _from_dict(cls, _dict):
             return cls(**args)
 
     mock = MockModel('foo')
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
     model1 = service._convert_model(mock)
     assert model1 == {'x': 'foo'}
 
@@ -352,14 +352,14 @@ def _from_dict(cls, _dict):
     assert res_str == 'default,123'
 
 def test_default_headers():
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
     service.set_default_headers({'xxx': 'yyy'})
     assert service.default_headers == {'xxx': 'yyy'}
     with pytest.raises(TypeError):
         service.set_default_headers('xxx')
 
 def test_set_url():
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
     with pytest.raises(ValueError) as err:
         service.set_url('{url}')
     assert str(err.value) == 'The url shouldn\'t start or end with curly brackets or quotes. Be sure to remove any {} and \" characters surrounding your url'
@@ -373,7 +373,7 @@ def test_get_authenticator():
 
 @responses.activate
 def test_user_agent_header():
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
     user_agent_header = service.user_agent_header
     assert user_agent_header is not None
     assert user_agent_header['User-Agent'] is not None
@@ -397,7 +397,7 @@ def test_user_agent_header():
 
 @responses.activate
 def test_files():
-    service = AnyServiceV1('2018-11-20')
+    service = AnyServiceV1('2018-11-20', authenticator=NoauthAuthenticator())
 
     responses.add(
         responses.GET,