chore(key): can't replace key but only convert to lower

Author: ehdsouza

ibm_cloud_sdk_core/utils.py

@@ -135,7 +135,7 @@ def read_from_credential_file(service_name, separator='='):
 
 def _parse_key_and_update_config(config, service_name, key, value):
     service_name = service_name.replace(' ', '_').replace('-', '_').lower()
-    key = key.replace(' ', '_').replace('-', '_').lower()
+    key = key.lower()
     if key.startswith(service_name):
         config[key[len(service_name) + 1:]] = value
 

resources/ibm-credentials-iam.env

@@ -1,4 +1,4 @@
-IBM-WATSON_APIKEY=5678efgh
-IBM-WATSON_AUTH_TYPE=iam
-IBM-WATSON_URL=https://gateway-s.watsonplatform.net/watson/api
-IBM-WATSON_DISABLE_SSL=False
+IBM_WATSON_APIKEY=5678efgh
+IBM_WATSON_AUTH_TYPE=iam
+IBM_WATSON_URL=https://gateway-s.watsonplatform.net/watson/api
+IBM_WATSON_DISABLE_SSL=False

test/test_utils.py

@@ -88,8 +88,8 @@ def test_vcap_credentials():
     del os.environ['VCAP_SERVICES']
 
 def test_multi_word_service_name():
-    os.environ['PERSONALITY-INSIGHTS_APIKEY'] = '5678efgh'
+    os.environ['PERSONALITY_INSIGHTS_APIKEY'] = '5678efgh'
     authenticator = get_authenticator_from_environment('personality-insights')
     assert authenticator is not None
     assert authenticator.token_manager.apikey == '5678efgh'
-    del os.environ['PERSONALITY-INSIGHTS_APIKEY']
+    del os.environ['PERSONALITY_INSIGHTS_APIKEY']